Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Normalize the option to post coverage as PR comment #210

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix: Normalize the option to post coverage as PR comment #210

merged 2 commits into from
Feb 13, 2024

Conversation

cicdguy
Copy link
Contributor

@cicdguy cicdguy commented Feb 13, 2024

This should bring back the coverage PR comment on this repo.

@cicdguy cicdguy self-assigned this Feb 13, 2024
@cicdguy cicdguy requested a review from a team as a code owner February 13, 2024 15:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

Unit Tests Summary

3 tests   3 ✅  6s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit 1db4a45.

♻️ This comment has been updated with latest results.

walkowif
walkowif approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@walkowif walkowif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

badge

Code Coverage Summary

Filename      Stmts    Miss  Cover    Missing
----------  -------  ------  -------  ---------
R/hello.R        20       6  70.00%   55-60
TOTAL            20       6  70.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 1db4a45

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@cicdguy cicdguy merged commit 2b7d0a7 into main Feb 13, 2024
23 checks passed
@cicdguy cicdguy deleted the fix/normalize-coverage-comment-option branch February 13, 2024 15:58
@cicdguy
Copy link
Contributor Author

cicdguy commented Feb 13, 2024 •
edited
Loading

@pawelru - Shiny tests are recorded in the coverage report, but Plumber tests are not (lines 55-60).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walkowif walkowif walkowif approved these changes

Assignees

@cicdguy cicdguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cicdguy @walkowif